CS 3733 Operating Systems, Fall 2000 Assignment 1 Comments
Warning: This is not for the current semester.
If I put a circled number on your assignment, it probably refers to one of the
numbers below.
The assignment was graded on a basis of 30 points.
Two points was deducted for each of the following problems:
- Not using a macro to test the status from wait.
- Waiting for the children in the loop that creates the children.
- Serious lint warnings
- The test output you turned in was not sufficient.
If additional points were taken off, there should be am explanation
written somewhere on your assignment.
Some comments about this assignment:
- In makeargv use an automatic variable for the new strtok_r parameter.
- You need to create all of the children, and then wait for them, rather
than waiting for one before creating the next.
- Use the macro WEXITSTATUS to determine the return status.
- No line of source code should be longer than 80 characters.
- One space of indentation per level is not enough. 10 is too many.
- Do not use WNOHANG option of waitpid, you have nothing to do
if no child has completed.
- Put in print statement after exec in case the exec fails.
- You should not use perror after fprintf.